feat(ourlogs): Add project badge to log row #100910
Open
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a small project badge to log rows so users can tell which project a log line is from at a glance when looking at multiple projects. Other: - This memoizes project badge as we shouldn't be rerendering ~2-5ms components when none of the props change, this especially hurts log table performance as hundreds of lines can be rendered at once.
github-actions
bot
added
the
Scope: Frontend
Dhrumil-Sentry
approved these changes
Oct 3, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
| const projectId: (typeof AlwaysPresentLogFields)[1] = | ||
| dataRow[OurLogKnownFieldKey.PROJECT_ID]; | ||
| const project = projects.projects.find(p => p.id === '' + projectId); |
There was a problem hiding this comment.
Bug: Project Badge Rendering Issue
Replacing useProjectFromId with a lookup in useProjects().projects could prevent project badges from rendering. This happens if useProjects() doesn't include all visible projects, or due to a type mismatch when comparing p.id with projectId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small project badge to log rows so users can tell which project a log line is from at a glance when looking at multiple projects.
Other:
Closes LOGS-385